Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expression Layer #162

Merged
merged 8 commits into from
Aug 25, 2023
Merged

Expression Layer #162

merged 8 commits into from
Aug 25, 2023

Conversation

ryanmrichard
Copy link
Member

@ryanmrichard ryanmrichard commented Aug 21, 2023 •
edited
Loading

This is r2g as long as CI passes. Same deal as previous PRs, I recommend merging and commenting on the resulting HTML docs.

@ryanmrichard ryanmrichard self-assigned this Aug 21, 2023
@ryanmrichard ryanmrichard marked this pull request as ready for review August 25, 2023 20:14
@ryanmrichard
Copy link
Member Author

@yzhang-23 I think the changes you've been making broke the stack because not everything was ready for Python to be enabled.

@ryanmrichard ryanmrichard merged commit 4901a8c into master Aug 25, 2023
@ryanmrichard ryanmrichard deleted the expression branch August 25, 2023 20:17
@yzhang-23
Copy link
Contributor

@yzhang-23 I think the changes you've been making broke the stack because not everything was ready for Python to be enabled.
Now I only turned on Python testing for ParallelZone, and I will be more cautious for other repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ryanmrichard ryanmrichard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanmrichard @yzhang-23