-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make completion signatures depend on the Receiver type #1337
base: main
Are you sure you want to change the base?
Conversation
Have you considered doing away with get_completion_signatures and just having connect, with the completion signatures as a nested typedef on the operation state? |
Hm Im not sure whether computing completion sigs can require a complete definition of the operation state. I think it must require a complete definition of the receiver, tho (for what i try to achieve) |
I wonder if this experiment would be easier in the smaller, cleaner ustdex repo. |
i have made this change in the ericniebler/ustdex and it works well. this is the direction i would like to pursue for stdexec. |
concept sender_of = // | ||
sender_in<_Sender, _Env> // | ||
sender_in<_Sender, _Receiver> // |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the sender_in
concept is no longer needed, right? sender_to
is enough.
This draft PR tracks my attempt to make
get_completion_signatures
take the receiver type instead of the env. If that works out it would solve some pending issues wrt to detecting whether connecting child senders throws or not.