Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make completion signatures depend on the Receiver type #1337

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maikel
Copy link
Collaborator

@maikel maikel commented May 20, 2024

This draft PR tracks my attempt to make get_completion_signatures take the receiver type instead of the env. If that works out it would solve some pending issues wrt to detecting whether connecting child senders throws or not.

Copy link

copy-pr-bot bot commented May 20, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@maikel maikel marked this pull request as draft May 20, 2024 17:47
@ericniebler
Copy link
Collaborator

Have you considered doing away with get_completion_signatures and just having connect, with the completion signatures as a nested typedef on the operation state?

@maikel
Copy link
Collaborator Author

maikel commented May 21, 2024

Have you considered doing away with get_completion_signatures and just having connect, with the completion signatures as a nested typedef on the operation state?

Hm Im not sure whether computing completion sigs can require a complete definition of the operation state. I think it must require a complete definition of the receiver, tho (for what i try to achieve)

@ericniebler
Copy link
Collaborator

I wonder if this experiment would be easier in the smaller, cleaner ustdex repo.

@ericniebler
Copy link
Collaborator

Have you considered doing away with get_completion_signatures and just having connect, with the completion signatures as a nested typedef on the operation state?

i have made this change in the ericniebler/ustdex and it works well. this is the direction i would like to pursue for stdexec.

concept sender_of = //
sender_in<_Sender, _Env> //
sender_in<_Sender, _Receiver> //
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the sender_in concept is no longer needed, right? sender_to is enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants