Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify nullable=False when generating filter values in dpp tests #9818

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Specify nullable=False when generating filter values in dpp tests #9818

merged 3 commits into from
Nov 21, 2023

Conversation

andygrove
Copy link
Contributor

@andygrove andygrove commented Nov 21, 2023 •
edited
Loading

Closes #9817

The dpp tests fail if we generate a null filter value because it gets translated to None literal in the SQL, resulting in the following error:

A column or function parameter with name `None` cannot be resolved. 
Did you mean one of the following? [`dim`.`key`, `fact`.`key`, `dim`.`skey`, `fact`.`skey`, `dim`.`value`]

I tested this manually using the seed value from the issue.

@andygrove andygrove self-assigned this Nov 21, 2023
revans2
revans2 previously approved these changes Nov 21, 2023
View reviewed changes
integration_tests/src/main/python/dpp_test.py Show resolved Hide resolved
@andygrove
Copy link
Contributor Author

build

@sameerz sameerz added the bug Something isn't working label Nov 21, 2023
@jlowe jlowe added the test Only impacts tests label Nov 21, 2023
@jlowe jlowe merged commit 1afead7 into NVIDIA:branch-23.12 Nov 21, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@revans2 revans2 revans2 approved these changes

@jlowe jlowe jlowe approved these changes

Assignees

@andygrove andygrove

Labels
bug Something isn't working test Only impacts tests
Projects
None yet
Milestone
No milestone
4 participants
@andygrove @jlowe @revans2 @sameerz