Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Partial Delta Lake Support for Databricks 13.3 #9644

Merged
merged 25 commits into from
Nov 14, 2023

Conversation

razajafri
Copy link
Collaborator

@razajafri razajafri commented Nov 6, 2023

This pull request aims to introduce support for Delta Lake on Databricks 13.3, enabling enhanced data management capabilities within the Databricks ecosystem. The integration of Delta Lake is essential for ensuring robust data handling and efficient data processing functionalities.

Known Issues:

  • There is identified code duplication, which will be resolved through the introduction of shims or a similar mechanism, as part of addressing issue 9643. This approach will streamline the codebase and ensure efficient management of shared functionalities.
  • Some integration tests are failing that will be addressed in future PRs. They are xfailed in this PR

Changes Made:

Delta Lake Integration: The PR includes the necessary modifications to seamlessly integrate Delta Lake functionality into the Databricks 13.3 environment, allowing users to leverage advanced data management features such as version control and transactional capabilities.

Contributes towards issue 9175

Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review, have not gotten through all the files yet.

Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's here looks OK, but seems like there's things that are missing, as the changes ni #9677 imply there's a lot of tests still failing after this.

@razajafri
Copy link
Collaborator Author

build

@razajafri razajafri changed the title Add Delta Lake Support for Databricks 13.3 Add Partial Delta Lake Support for Databricks 13.3 Nov 13, 2023
@razajafri
Copy link
Collaborator Author

razajafri commented Nov 13, 2023

premerge will fail until #9688 is merged

@razajafri
Copy link
Collaborator Author

Build

@jlowe
Copy link
Member

jlowe commented Nov 14, 2023

build

@jlowe jlowe merged commit df9fb5a into NVIDIA:branch-23.12 Nov 14, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants