Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OverwriteByExpressionExecV1 for Delta Lake tables [databricks] #9546

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Oct 25, 2023

Fixes #7279.

Adds GpuOverwriteByExpressionExecV1 and support for the V1 Write instance provided by Delta Lake. Ported some of the tests over from the Delta Lake project which helped discover that, unlike Apache Spark, Databricks will use a different node for dynamic partition overwrite. Filed #9543 to track handling that new node and xfailed the affected tests on Databricks in the interim.

@jlowe jlowe self-assigned this Oct 25, 2023
@jlowe
Copy link
Member Author

jlowe commented Oct 25, 2023

build

@jlowe jlowe changed the title Support OverwriteByExpressionExecV1 for Delta Lake tables Support OverwriteByExpressionExecV1 for Delta Lake tables [databricks] Oct 25, 2023
Copy link
Collaborator

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still hate the TODOs from the deltalake code showing up. It gets me every time I see them.

@jlowe jlowe merged commit 932c811 into NVIDIA:branch-23.12 Oct 26, 2023
30 of 31 checks passed
@jlowe jlowe deleted the delta-obeev1 branch October 26, 2023 14:31
@sameerz sameerz added the feature request New feature or request label Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Support OverwriteByExpressionExecV1 for Delta Lake
3 participants