-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Shim JSON Headers for Databricks 13.3 #9488
Add Shim JSON Headers for Databricks 13.3 #9488
Conversation
Signed-off-by: Raza Jafri <[email protected]>
build |
The PR headline should be updated to be a bit more descriptive. As it is, it implies this PR adds support for Databricks 13.3 which isn't quite accurate. |
If this PR merely shimplify-generated it would help if we can see the command line used in the description. Should spark341db.RapidsShuffleManager be part of the PR? |
Thank you for the comment. This isn't just shimplify-generated code but a commit from a branch that is already building. I have just broken the commits down so they are easier to review. You can see the branch here. The RapidsShuffleManager will be a part of the boilerplate that will follow in subsequent PRs. |
build |
In the future It is easier for the reviews if we follow the standard procedure that also takes care of the RapidsShuffleManager spark-rapids/docs/dev/shimplify.md Lines 185 to 187 in 97089e6
|
I do see your point. In this case, however, breaking down the commits into smaller chunked PRs was an afterthought. I agree it would've helped to review the changes if it was just the shimplify-generated code or something repeatable by the reviewers |
You can add 13.3 in the below line to run pre-merge CI with Databricks 13.3 against your PR, |
Thanks, I will add it after the pom changes are in as we aren't building against 13.3 yet. |
This pull request introduces support for Databricks 13.3. This PR is part of a series of PRs that will address the complete support for Databricks 13.3. The primary focus of this PR is the addition of necessary shims for 341db.
Changes Made:
Shims for 341db: This PR includes the implementation of shims to support this version of Databricks, ensuring that our codebase remains compatible.
Testing:
Tests will be addressed in subsequent PRs
contributes towards #9175