Add support for Cloudera CDS-3.3.2 #9396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rishi <[email protected]>
sririshindra
requested review from
jlowe,
revans2,
tgravescs,
GaryShen2008,
NvTimLiu and
zhanga5
as code owners
|
build |
sameerz
added
the
task
tgravescs
reviewed
Oct 6, 2023
...n/spark332cdh/scala/com/nvidia/spark/rapids/shims/spark332cdh/SparkShimServiceProvider.scala
Outdated
Show resolved
Hide resolved
...n/spark332cdh/scala/com/nvidia/spark/rapids/shims/spark332cdh/SparkShimServiceProvider.scala
Outdated
Show resolved
Hide resolved
...in/src/main/spark332cdh/scala/com/nvidia/spark/rapids/spark332cdh/RapidsShuffleManager.scala
Outdated
Show resolved
Hide resolved
...32cdh/scala/org/apache/spark/sql/rapids/shims/spark332cdh/RapidsShuffleInternalManager.scala
Outdated
Show resolved
Hide resolved
...n/src/test/spark332cdh/scala/com/nvidia/spark/rapids/shims/spark332cdh/SparkShimsSuite.scala
Outdated
Show resolved
Hide resolved
winningsix
reviewed
Oct 6, 2023
...src/main/spark350/scala/org/apache/spark/sql/execution/rapids/shims/FilePartitionShims.scala
Show resolved
Hide resolved
Change-Id: I0c4427947d4db88d7d96ccc0f59a8cb5ba4813c6
pom.xml
Outdated
Comment on lines
476
to
493
| <repositories> | ||
| <repository> | ||
| <id>cloudera-repo</id> | ||
| <url>https://repository.cloudera.com/artifactory/cloudera-repos/</url> | ||
| <releases> | ||
| <enabled>true</enabled> | ||
| </releases> | ||
| <snapshots> | ||
| <enabled>true</enabled> | ||
| </snapshots> | ||
| </repository> | ||
| </repositories> | ||
| <pluginRepositories> | ||
| <pluginRepository> | ||
| <id>cloudera-repo</id> | ||
| <url>https://repository.cloudera.com/artifactory/cloudera-repos/</url> | ||
| </pluginRepository> | ||
| </pluginRepositories> |
There was a problem hiding this comment.
We get more and more of these. Let us move repeated repo definitions out of all CDH profiles and have them defined in the global lists at the bottom of the pom like this:
<repositories>
...
<repository>
<id>cloudera-repo</id>
<url>https://repository.cloudera.com/artifactory/cloudera-repos/</url>
<releases>
<enabled>${cloudera.repo.enabled}</enabled>
</releases>
<snapshots>
<enabled>${cloudera.repo.enabled}</enabled>
</snapshots>
</repository>
</repositories>
<pluginRepositories>
...
<pluginRepository>
<id>cloudera-repo</id>
<url>https://repository.cloudera.com/artifactory/cloudera-repos/</url>
<releases>
<enabled>${cloudera.repo.enabled}</enabled>
</releases>
<snapshots>
<enabled>${cloudera.repo.enabled}</enabled>
</snapshots>
</pluginRepository>
</pluginRepositories>the we can add just a single line to each CDH profile properties:
<cloudera.repo.enabled>true</cloudera.repo.enabled>| override def getShimVersion: ShimVersion = SparkShimServiceProvider.VERSION | ||
|
|
||
| def matchesVersion(version: String): Boolean = { | ||
| version.contains(SparkShimServiceProvider.CDH_BASE_VERSION) |
There was a problem hiding this comment.
I guess we always do it like this, but wonder if it should be more restrictive like startsWith or equality after stripping spaces etc.
There was a problem hiding this comment.
I think this could be on a shim specific case depending on what we are expecting. But if we want to look at it, I propose we file a separate issue as it affects more then this shim.
...src/main/spark350/scala/org/apache/spark/sql/execution/rapids/shims/FilePartitionShims.scala
Show resolved
Hide resolved
|
@sririshindra can you update to resolve the conflicts with the files when you have time? |
added 2 commits
October 14, 2023 07:43
Change-Id: I9f05def7dae9b0a6e63b6ac40460f12a7847708c
…332cdh Change-Id: I76ee6e036136919a1cdb0b95cb67bf19c35292bc
|
build |
tgravescs
approved these changes
Oct 16, 2023
|
build |
sririshindra
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add support for Cloudera's CDS-3.3.2 spark release. This is quite similar to CDS3.3.0 release.