-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle escaping the dangling right ] and right } in the regexp transpiler #9239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… transpiler to ensure compatibility with cudf Signed-off-by: Navin Kumar <[email protected]>
Signed-off-by: Navin Kumar <[email protected]>
build |
jlowe
previously approved these changes
Sep 18, 2023
Looks like a couple of unit test failures:
|
revans2
previously approved these changes
Sep 18, 2023
Signed-off-by: Navin Kumar <[email protected]>
build |
revans2
approved these changes
Sep 18, 2023
@@ -52,7 +52,7 @@ class RegularExpressionParserSuite extends AnyFunSuite { | |||
test("not a quantifier") { | |||
assert(parse("{1}") === |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay so because there is nothing in front of the {1}
that we do not parse it as a repetition.
jlowe
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9224.
This enables the transpiler to automatically escape
]
and}
when they have no left component. This ensures that they will run in optimized form when regex is not required, and will be escaped properly for cuDF.