Add in new HostAlloc API #9170
Merged
Add in new HostAlloc API #9170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert (Bobby) Evans <[email protected]>
jlowe
reviewed
Sep 1, 2023
sql-plugin/src/main/scala/com/nvidia/spark/rapids/HostAlloc.scala
Outdated
Show resolved
Hide resolved
abellina
reviewed
Sep 5, 2023
|
|
||
| import org.apache.spark.TaskContext | ||
|
|
||
| private class HostAlloc(nonPinnedLimit: Long) { |
There was a problem hiding this comment.
nit, should we used "pageable" instead of "non-pinned"?
There was a problem hiding this comment.
If you really want me to I will. Is it unclear the type of memory being allocated?
There was a problem hiding this comment.
It's a nit, not a must fix. It is clear to me that non-pinned is pageable.
|
|
||
| import org.apache.spark.TaskContext | ||
|
|
||
| private class HostAlloc(nonPinnedLimit: Long) { |
There was a problem hiding this comment.
suggest we call this HostAllocator.
There was a problem hiding this comment.
If you really want me to I will. Is it unclear what this does?
There was a problem hiding this comment.
the main nit I had was that HostAlloc sounded more like a product of an allocator than the allocator itself, but it's just a nit. Not a must fix.
sql-plugin/src/main/scala/com/nvidia/spark/rapids/HostAlloc.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/HostAlloc.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/HostAlloc.scala
Outdated
Show resolved
Hide resolved
|
build |
jlowe
reviewed
Sep 5, 2023
sql-plugin/src/main/scala/com/nvidia/spark/rapids/HostAlloc.scala
Outdated
Show resolved
Hide resolved
|
build |
jlowe
approved these changes
Sep 5, 2023
sameerz
added
the
reliability
abellina
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #8879
The dependency for this was merged into CUDF today, but it may be a little while before this can be merged/tested.