Mark lazy spillables as allowSpillable in during gatherer construction #8989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alessandro Bellina <[email protected]>
jlowe
approved these changes
Aug 10, 2023
revans2
approved these changes
Aug 10, 2023
|
build |
sameerz
added
the
reliability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8942
This fixes a memory pressure issue when creating gatherers in
GpuHashJoin. At 100K we saw query14_part1 and query14_part2 fail with OOM right around this part of the code. It looks like we were keeping the build and stream data batches non-spillable as we created the gather map. This change makes it so we can spill the data sides during this operation.I do not see regressions with this change at NDS 3TB. This change allows query14_part1 and part2 to succeed on every test I have tried.
I really want to remove LazySpillable, but I'll save that for a different PR.