Move big data generator to a separate module #8988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Lowe <[email protected]>
jlowe
requested review from
revans2,
tgravescs,
GaryShen2008,
NvTimLiu and
zhanga5
as code owners
|
build |
abellina
reviewed
Aug 10, 2023
| @@ -27,13 +26,13 @@ If you are building with a jdk version that is not 8, you will need to add in th | |||
| corresponding profile flag `-P<jdk11|jdk17>` | |||
|
|
|||
| After this the jar should be at | |||
| `target/rapids-4-spark-integration-tests_2.12-$PLUGIN_VERSION-spark$SPARK_VERSION.jar` | |||
| `target/datagen_2.12-$PLUGIN_VERSION-spark$SPARK_VERSION.jar` | |||
There was a problem hiding this comment.
should this jar be something like rapids-4-spark-datagen? I guess we are not publishing it, so maybe that's not such a big deal (feels a bit generic)
There was a problem hiding this comment.
I originally had it named that way, but there's nothing in it specific to the RAPIDS Accelerator for Apache Spark. It only uses Apache Spark interfaces and doesn't require the RAPIDS Accelerator.
abellina
approved these changes
Aug 10, 2023
revans2
approved these changes
Aug 10, 2023
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the data generator out of the integration_tests module and into its own module, making it simpler to pull in as a dependency and more focused if we decide to publish the build artifact later.