Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix host memory buffer leaks in SerializationSuite #8987

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Fix host memory buffer leaks in SerializationSuite #8987

merged 1 commit into from
Aug 11, 2023

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Aug 10, 2023

Saw some logged leaks in recent unit test runs and tracked them down to host memory buffer leaks in SerializationSuite. This fixes those host memory buffer leaks.

@jlowe jlowe added the test Only impacts tests label Aug 10, 2023
@jlowe jlowe requested a review from abellina August 10, 2023 20:00
@jlowe jlowe self-assigned this Aug 10, 2023
@jlowe
Copy link
Member Author

jlowe commented Aug 10, 2023

build

@revans2
Copy link
Collaborator

revans2 commented Aug 10, 2023

build

gerashegalov
gerashegalov approved these changes Aug 10, 2023
View reviewed changes
Copy link
Collaborator

@gerashegalov gerashegalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

abellina
abellina approved these changes Aug 10, 2023
View reviewed changes
Copy link
Collaborator

@abellina abellina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@jlowe jlowe merged commit a52acff into NVIDIA:branch-23.10 Aug 11, 2023
28 checks passed
@jlowe jlowe deleted the fix-serialization-test-leak branch August 11, 2023 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@revans2 revans2 revans2 approved these changes

@gerashegalov gerashegalov gerashegalov approved these changes

@abellina abellina abellina approved these changes

Assignees

@jlowe jlowe

Labels
test Only impacts tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jlowe @revans2 @abellina @gerashegalov