Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JNI and private version to released 23.08.0 [databricks] #8949

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

pxLi
Copy link
Collaborator

@pxLi pxLi commented Aug 8, 2023

bump up JNI and private versions to 23.08.0

NOTE: I will trigger CI after JNI and private artifacts are available at maven central

@pxLi pxLi added the build Related to CI / CD or cleanly building label Aug 8, 2023
@pxLi
Copy link
Collaborator Author

pxLi commented Aug 11, 2023

build

@pxLi pxLi marked this pull request as ready for review August 11, 2023 06:07
@pxLi
Copy link
Collaborator Author

pxLi commented Aug 11, 2023

please ignore failed spark333test (release private do not include snapshot shims)
mvn[compile,RAT,scalastyle,docgen] / package-tests (333, true) (pull_request)

@pxLi pxLi requested a review from YanxuanLiu August 11, 2023 09:14
@pxLi pxLi merged commit 5717010 into NVIDIA:branch-23.08 Aug 11, 2023
24 of 25 checks passed
@revans2
Copy link
Collaborator

revans2 commented Aug 11, 2023

We had test failures for this. Why is it that we didn't disable the 333 pre-commit? Any PR after this for 3.8 is also not going to pass.

@pxLi
Copy link
Collaborator Author

pxLi commented Aug 14, 2023

We had test failures for this. Why is it that we didn't disable the 333 pre-commit? Any PR after this for 3.8 is also not going to pass.

This should be the last change for pre-release, if any followups people could just ignore the optional snapshot shim test.

And yes, we could add some specific control to make sure we skip the snapshot shims in github actions.
Currently due to our auto-merge strategy, we will always update in multiple places to make sure that the change would not also fail/forget required shims the current dev branches (one change to disable pre-release, auto-merge to disable in dev, and then another one to enable back in dev)

If needed, we can consider adding some global VAR to control instead of oral notification or code changes in multiple branches. filed #9020, I will check if any good solution for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to CI / CD or cleanly building
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants