Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop the in-range check at INT96 output path [databricks] #8824

Merged
merged 15 commits into from
Aug 4, 2023
Merged

Drop the in-range check at INT96 output path [databricks] #8824

merged 15 commits into from
Aug 4, 2023

Conversation

gerashegalov
Copy link
Collaborator

@gerashegalov gerashegalov commented Jul 27, 2023 •
edited
Loading

  • Remove INT96 check for being in the Long.Min:Max range.
  • Update docs and tests

Fixes #8625

Depends on rapidsai/cudf#8070, rapidsai/cudf#13776

Verified with the notebook and

JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 TEST_PARALLEL=0 SPARK_HOME=~/dist/spark-3.3.2-bin-hadoop3 ./integration_tests/run_pyspark_from_build.sh -k test_fix_for_int96_overflow

Signed-off-by: Gera Shegalov [email protected]

@gerashegalov gerashegalov self-assigned this Jul 27, 2023
@gerashegalov gerashegalov added the cudf_dependency An issue or PR with this label depends on a new feature in cudf label Jul 27, 2023
revans2
revans2 previously approved these changes Jul 27, 2023
View reviewed changes
@gerashegalov
Update docs and tests
f266ea3 
Signed-off-by: Gera Shegalov <[email protected]>
@gerashegalov gerashegalov linked an issue Jul 28, 2023 that may be closed by this pull request
[FEA] Support outputTimestampType being INT96 #8625
Closed
revans2
revans2 previously approved these changes Jul 28, 2023
View reviewed changes
Copy link
Collaborator

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks great

@sameerz sameerz added the reliability Features to improve reliability or bugs that severly impact the reliability of the plugin label Jul 31, 2023
@gerashegalov gerashegalov marked this pull request as ready for review August 3, 2023 17:40
@gerashegalov
Copy link
Collaborator Author

build

@gerashegalov gerashegalov changed the title [WIP] Drop the in-range check at INT96 output path Drop the in-range check at INT96 output path Aug 3, 2023
@gerashegalov
Copy link
Collaborator Author

build

@gerashegalov gerashegalov changed the title Drop the in-range check at INT96 output path Drop the in-range check at INT96 output path [databricks] Aug 4, 2023
@gerashegalov
Copy link
Collaborator Author

build

@gerashegalov gerashegalov merged commit 3e72774 into NVIDIA:branch-23.10 Aug 4, 2023
27 checks passed
@gerashegalov gerashegalov deleted the int96 branch August 4, 2023 22:20
@gerashegalov gerashegalov mentioned this pull request Aug 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe approved these changes

@revans2 revans2 revans2 left review comments

Assignees

@gerashegalov gerashegalov

Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf reliability Features to improve reliability or bugs that severly impact the reliability of the plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Support outputTimestampType being INT96
4 participants
@gerashegalov @jlowe @revans2 @sameerz