Add config to override shims provider class #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Lowe <[email protected]>
jlowe
added
feature request
|
build |
revans2
previously approved these changes
Sep 15, 2020
tgravescs
reviewed
Sep 15, 2020
sql-plugin/src/main/scala/com/nvidia/spark/rapids/RapidsConf.scala
Outdated
Show resolved
Hide resolved
tgravescs
previously approved these changes
Sep 15, 2020
Signed-off-by: Jason Lowe <[email protected]>
|
build |
tgravescs
approved these changes
Sep 15, 2020
NvTimLiu
pushed a commit
to NvTimLiu/spark-rapids
that referenced
this pull request
Sep 15, 2020
* Add config to override shims provider class Signed-off-by: Jason Lowe <[email protected]> * Update docs for shims provider override config Signed-off-by: Jason Lowe <[email protected]>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Add config to override shims provider class Signed-off-by: Jason Lowe <[email protected]> * Update docs for shims provider override config Signed-off-by: Jason Lowe <[email protected]>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Add config to override shims provider class Signed-off-by: Jason Lowe <[email protected]> * Update docs for shims provider override config Signed-off-by: Jason Lowe <[email protected]>
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
…IDIA#765) Signed-off-by: spark-rapids automation <[email protected]> Signed-off-by: spark-rapids automation <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #409 but only partially addresses it.
This provides an internal config property that allows a user to override the normal, automatic shim detection logic. This can be used to force a particular shim provider class to be used in cases where the shim detection logic does not work (e.g.: when the reported Spark version is unrecognized).
A warning is emitted when the shims provider is overridden as it is very likely the combination of Spark version and shim version is untested and may not fully function properly.