Small fix for race in catalog where a buffer could get spilled while … #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not registered in the device catalog to begin with Signed-off-by: Alessandro Bellina <[email protected]>
jlowe
approved these changes
Sep 2, 2020
|
build |
jlowe
added
bug
|
All runs I've done with this fix look fine (no race), so I'll merge this one. Thanks @jlowe |
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…not registered in the device catalog to begin with (NVIDIA#644) Signed-off-by: Alessandro Bellina <[email protected]>
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…not registered in the device catalog to begin with (NVIDIA#644) Signed-off-by: Alessandro Bellina <[email protected]>
4 tasks
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
* Revert "verify automerge fix of Token permission (NVIDIA#643)" This reverts commit 8261117. * Revert "try use new token to fix automerge permission" This reverts commit 2a9acde. Signed-off-by: Peixin Li <[email protected]> Signed-off-by: Peixin Li <[email protected]>
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
* Update submodule cudf to f817d96d8bdc47da9fb2725d0e5a7b18586a29ee (NVIDIA#635) Signed-off-by: spark-rapids automation <[email protected]> Signed-off-by: spark-rapids automation <[email protected]> * Fixing empty columns when casting to integer or decimal crashing (NVIDIA#633) * fixing empty columns Signed-off-by: Mike Wilson <[email protected]> * cudf submodule commit to v22.10.00 (NVIDIA#640) Signed-off-by: Peixin Li <[email protected]> Signed-off-by: Peixin Li <[email protected]> * try use new token to fix automerge permission * verify automerge fix of Token permission (NVIDIA#643) Signed-off-by: Peixin Li <[email protected]> Signed-off-by: Peixin Li <[email protected]> * Revert not working automerge fix [skip ci] (NVIDIA#644) * Revert "verify automerge fix of Token permission (NVIDIA#643)" This reverts commit 8261117. * Revert "try use new token to fix automerge permission" This reverts commit 2a9acde. Signed-off-by: Peixin Li <[email protected]> Signed-off-by: Peixin Li <[email protected]> * Auto-merge use submodule in BASE ref Signed-off-by: Peixin Li <[email protected]> Signed-off-by: spark-rapids automation <[email protected]> Signed-off-by: Mike Wilson <[email protected]> Signed-off-by: Peixin Li <[email protected]> Co-authored-by: Jenkins Automation <[email protected]> Co-authored-by: Mike Wilson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it impossible for a spill to happen while we are adding a buffer, which is the issue reported here (#643).
Closes #643