Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Init workflow for blossom-ci #642

Merged
merged 8 commits into from
Sep 10, 2020
Merged

Init workflow for blossom-ci #642

merged 8 commits into from
Sep 10, 2020

Conversation

pxLi
Copy link
Collaborator

@pxLi pxLi commented Sep 2, 2020 •
edited
Loading

This PR is ready for review.

So the plan is that we will have two premerge pipelines(ngcc+blossom) running concurrently for a while, and we will not take blossom-ci as a required check until we think it is stable enough. After mark it as required, we will shutdown the ngcc premerge pipeline.

TO-DO:

  • (Admin Access to repo) Setup self-hosts runner and secrets for our repo. Also some setup work will reply on blossom team
  • Figure out dependent relation of blackduck scan and blossom-ci with blossom team

Demo PR on my forked repo:
pxLi#172

Demo actions log:
https://github.com/pxLi/spark-rapids/runs/1085285373?check_suite_focus=true

Steps to setup:
https://confluence.nvidia.com/display/SPARK/How+to+configure+Github+repo+to+support+blossom-ci+pipelines

NOTE:
Existing vulnerabilities will not block our CI pipeline, but new ones will. We should fix those existing ones in the future.

@pxLi
Copy link
Collaborator Author

pxLi commented Sep 2, 2020

build

@pxLi
Copy link
Collaborator Author

pxLi commented Sep 2, 2020

build

jlowe
jlowe previously approved these changes Sep 2, 2020
View reviewed changes
.github/workflows/blossom-ci.yml Show resolved Hide resolved
.github/workflows/signoff-check.yml Outdated Show resolved Hide resolved
@jlowe jlowe dismissed their stale review September 2, 2020 13:49

sorry, didn't mean to approve.

@sameerz sameerz added the build Related to CI / CD or cleanly building label Sep 2, 2020
@pxLi pxLi mentioned this pull request Sep 3, 2020
Merged
@pxLi
Copy link
Collaborator Author

pxLi commented Sep 3, 2020

build

@pxLi
Copy link
Collaborator Author

pxLi commented Sep 4, 2020

build

1 similar comment
@pxLi
Copy link
Collaborator Author

pxLi commented Sep 4, 2020

build

@pxLi
Copy link
Collaborator Author

pxLi commented Sep 8, 2020

build

@pxLi pxLi changed the title [WIP] init workflow for blossom-ci Init workflow for blossom-ci Sep 8, 2020
@pxLi pxLi requested a review from jlowe September 8, 2020 10:36
@pxLi
Copy link
Collaborator Author

pxLi commented Sep 8, 2020

Updated desc, this PR is ready fo review

tgravescs
tgravescs reviewed Sep 8, 2020
View reviewed changes
Copy link
Collaborator

@tgravescs tgravescs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so in pxLi#172 by the blossom-ci it says its "Required". Is that going to be there during transition period or will it say optional?

jenkins/Dockerfile-blossom.ubuntu16 Show resolved Hide resolved
jenkins/Jenkinsfile-blossom.premerge Outdated Show resolved Hide resolved
jenkins/Jenkinsfile-blossom.premerge Show resolved Hide resolved
@pxLi
Copy link
Collaborator Author

pxLi commented Sep 8, 2020 •
edited
Loading

so in pxLi#172 by the blossom-ci it says its "Required". Is that going to be there during transition period or will it say optional?

Yeah, it says required cause I enabled it as a required check, and yes it will be there and block merge until it get passed. If unchecked, it will just show us the check status but will not block merge operation.
image

@pxLi
Copy link
Collaborator Author

pxLi commented Sep 8, 2020

build

@pxLi pxLi requested a review from tgravescs September 9, 2020 00:11
tgravescs
tgravescs reviewed Sep 9, 2020
View reviewed changes
Copy link
Collaborator

@tgravescs tgravescs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.minor comment others seems fine assuming it all works.

jenkins/Dockerfile-blossom.ubuntu16 Outdated
@@ -0,0 +1,40 @@
#
# Copyright (c) 2019-2020, NVIDIA CORPORATION. All rights reserved.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove 2019 from copyright

pxLi and others added 2 commits September 9, 2020 08:57
@pxLi
Copy link
Collaborator Author

pxLi commented Sep 9, 2020

build

1 similar comment
@pxLi
Copy link
Collaborator Author

pxLi commented Sep 9, 2020

build

@pxLi
Copy link
Collaborator Author

pxLi commented Sep 9, 2020

build

@pxLi
Copy link
Collaborator Author

pxLi commented Sep 9, 2020

build

@jlowe
Copy link
Member

jlowe commented Sep 9, 2020

We only want blossom CI for premerge on branch-0.3, correct? If so, is it appropriate to target branch-0.2 with this?

@pxLi
Copy link
Collaborator Author

pxLi commented Sep 9, 2020 •
edited
Loading

We only want blossom CI for premerge on branch-0.3, correct? If so, is it appropriate to target branch-0.2 with this?

I think the plan is to enable this for both 0.2 and 0.3 (all branches that require CI checks), ngcc premerge pipeline will not be allowed in the future due to security concerns, and we have to retire it soon

@jlowe
Copy link
Member

jlowe commented Sep 9, 2020

I think the plan is to enable this for both 0.2 and 0.3, ngcc premerge pipeline will not be allowed in the future due to security concerns.

I was under the impression we weren't going to risk destabilizing the 0.2 premerge just before the imminent 0.2 release. Wondering if we should hold off on this until 0.2 is released. cc: @sameerz

@pxLi
Copy link
Collaborator Author

pxLi commented Sep 10, 2020 •
edited
Loading

FYI

I am going to merge this to test setup with blossom team.
So the blossom-ci will be a optional check in a few days, that means it will not block anyone from merge PRs.

We will send out a note to spark-dev before we make it a required check

@pxLi pxLi merged commit b08ef74 into NVIDIA:branch-0.2 Sep 10, 2020
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
@pxLi @NvTimLiu
Init workflow for blossom-ci (NVIDIA#642)
39c8acd 
* init workflow for blossom-ci

Signed-off-by: Peixin Li <[email protected]>

Co-authored-by: Tim Liu <[email protected]>
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
@pxLi @NvTimLiu
Init workflow for blossom-ci (NVIDIA#642)
a57607f 
* init workflow for blossom-ci

Signed-off-by: Peixin Li <[email protected]>

Co-authored-by: Tim Liu <[email protected]>
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this pull request Nov 30, 2023
@nvauto
Update submodule cudf to c824fee8181d06ba1c05a5de4d4ebc0a52027753 (NV…
a5dc685 
…IDIA#642)

Signed-off-by: spark-rapids automation <[email protected]>

Signed-off-by: spark-rapids automation <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgravescs tgravescs tgravescs approved these changes

@revans2 revans2 revans2 approved these changes

@GaryShen2008 GaryShen2008 Awaiting requested review from GaryShen2008 GaryShen2008 is a code owner

@NvTimLiu NvTimLiu Awaiting requested review from NvTimLiu NvTimLiu is a code owner

@jlowe jlowe Awaiting requested review from jlowe jlowe is a code owner

Assignees
No one assigned
Labels
build Related to CI / CD or cleanly building
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pxLi @jlowe @revans2 @tgravescs @sameerz