Move spark shim properties to top level pom #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niranjan Artal <[email protected]>
nartal1
requested review from
GaryShen2008,
jlowe,
NvTimLiu,
revans2 and
tgravescs
as code owners
Signed-off-by: Niranjan Artal <[email protected]>
|
build |
|
@tgravescs , Could you please take a look. Please let me know if there is any rules for placing the properties. I have added them at the end. |
revans2
approved these changes
Aug 12, 2020
tgravescs
approved these changes
Aug 12, 2020
nartal1
added a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Move spark shim properties to top level pom Signed-off-by: Niranjan Artal <[email protected]>
nartal1
added a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
* Move spark shim properties to top level pom Signed-off-by: Niranjan Artal <[email protected]>
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
…IDIA#549) Signed-off-by: spark-rapids automation <[email protected]> Signed-off-by: spark-rapids automation <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Niranjan Artal [email protected]
This is based off comment #539 (comment) . Since we could use versions in multiple pom files, moving those versions to top level pom.