Adds iterator and client unit tests, and prepares for more fetch failure handling #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fetch failure handling.
abellina
changed the title
revans2
reviewed
Jul 8, 2020
sql-plugin/src/main/scala/com/nvidia/spark/rapids/shuffle/RapidsShuffleClient.scala
Outdated
Show resolved
Hide resolved
jlowe
reviewed
Jul 8, 2020
sql-plugin/src/main/scala/com/nvidia/spark/rapids/MetaUtils.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/ShuffleBufferCatalog.scala
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/shuffle/RapidsShuffleClient.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/shuffle/RapidsShuffleClient.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/shuffle/RapidsShuffleClient.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/shuffle/RapidsShuffleIterator.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/shuffle/RapidsShuffleIterator.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/shuffle/RapidsShuffleIterator.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/shuffle/RapidsShuffleIterator.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/org/apache/spark/sql/rapids/RapidsShuffleInternalManager.scala
Outdated
Show resolved
Hide resolved
jlowe
reviewed
Jul 9, 2020
sql-plugin/src/main/scala/com/nvidia/spark/rapids/shuffle/RapidsShuffleIterator.scala
Show resolved
Hide resolved
jlowe
approved these changes
Jul 9, 2020
|
build |
revans2
approved these changes
Jul 10, 2020
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…ure handling (NVIDIA#331) * Adds iterator and client unit tests, and prepares the read side for fetch failure handling. * Remove synchronization that was added by mistake * Changes to address code review comments * Add a comment stating the thread safety expectations of removeBuffer * Add a comment on mapId vs mapIndex
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…ure handling (NVIDIA#331) * Adds iterator and client unit tests, and prepares the read side for fetch failure handling. * Remove synchronization that was added by mistake * Changes to address code review comments * Add a comment stating the thread safety expectations of removeBuffer * Add a comment on mapId vs mapIndex
pxLi
pushed a commit
to pxLi/spark-rapids
that referenced
this pull request
May 12, 2022
tgravescs
pushed a commit
to tgravescs/spark-rapids
that referenced
this pull request
Nov 30, 2023
…ilding framework (NVIDIA#331) * Added nvbench support to repo * Added Google Test framework to repo * Updating test framework to run in docker container Signed-off-by: Mike Wilson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial PR introducing the
RapidsShuffleFetchFailedExceptionand some usage, to try and address some of the issues brought up in: #326It also adds initial unit tests for the client side.
Note that the write side has a change squeezed in there. When a task fails, it will call the writer with
stop(false)to signify a failure during its processing. Prior to this PR, we would shut down the storage all-together => this would cause all peers to this executor to fail in the future, given that we would now reuse the executor's JVM. This change tracks these "uncomitted" ShuffleBufferIds at the writer level. @jlowe FYI, happy to split that off, handle it differently, but adding it here for discussion.