Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add index.md for default doc page, fix table formatting for configs #247

Merged
merged 1 commit into from
Jun 22, 2020
Merged

Add index.md for default doc page, fix table formatting for configs #247

merged 1 commit into from
Jun 22, 2020

Conversation

sameerz
Copy link
Collaborator

@sameerz sameerz commented Jun 21, 2020

  1. Please write a description in this text box of the changes that are being
    made.

Updated RapidsConf.scala to put newline after headings and before start of tables. Removed about.md and replaced it with an index.md, which will make the site public, even for a private repository.

  1. Please ensure that you have written units tests for the changes made/features
    added.

Automatically generated configs.md based on changes in RapidsConf.scala

@sameerz sameerz added the documentation Improvements or additions to documentation label Jun 21, 2020
@abellina abellina self-requested a review June 21, 2020 17:38
Copy link
Collaborator

@abellina abellina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @sameerz.

@sameerz
Copy link
Collaborator Author

sameerz commented Jun 21, 2020

build

@kuhushukla
Copy link
Collaborator

Minor nitty question. Approving..

docs/index.md Show resolved Hide resolved
@jlowe jlowe merged commit 6083ff9 into NVIDIA:branch-0.1 Jun 22, 2020
NvTimLiu pushed a commit to NvTimLiu/spark-rapids that referenced this pull request Sep 13, 2020
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this pull request Nov 30, 2023
Signed-off-by: spark-rapids automation <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants