Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated join tests to cover more data. #176

Merged
merged 1 commit into from
Jun 16, 2020
Merged

Updated join tests to cover more data. #176

merged 1 commit into from
Jun 16, 2020

Conversation

revans2
Copy link
Collaborator

@revans2 revans2 commented Jun 15, 2020

This fixes #156

The result was not wrong, just the sort was wrong for -0.0 as caused by #84

@revans2 revans2 added the test Only impacts tests label Jun 15, 2020
@revans2 revans2 self-assigned this Jun 15, 2020
@revans2
Copy link
Collaborator Author

revans2 commented Jun 15, 2020

build

Copy link
Collaborator

@nartal1 nartal1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @revans2. lgtm. I just wanted to know is there a reason we are seeing this issue in DoubleType and not in FloatType?

@revans2 revans2 merged commit f18d619 into NVIDIA:branch-0.1 Jun 16, 2020
@sameerz sameerz added this to the Jun 8 - Jun 19 milestone Jun 16, 2020
@revans2 revans2 deleted the join_test_fixes branch June 17, 2020 14:48
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
nartal1 pushed a commit to nartal1/spark-rapids that referenced this pull request Jun 9, 2021
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this pull request Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Only impacts tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Incorrect result in InnerJoin and LeftSemiJoin for DoubleType when using larger data sizes
3 participants