Support faster copy for a custom DataSource V2 which supplies Arrow data #1622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Graves <[email protected]>
|
build |
|
build |
|
upmerging |
|
build |
revans2
reviewed
Jan 29, 2021
sql-plugin/src/main/scala/com/nvidia/spark/rapids/HostColumnarToGpu.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/HostColumnarToGpu.scala
Outdated
Show resolved
Hide resolved
sql-plugin/src/main/scala/com/nvidia/spark/rapids/HostColumnarToGpu.scala
Outdated
Show resolved
Hide resolved
|
build |
revans2
reviewed
Jan 29, 2021
| "access its Arrow ValueVector", e) | ||
| } | ||
| case av: AccessibleArrowColumnVector => | ||
| // val arrowVec = av.asInstanceOf[AccessibleArrowColumnVector] |
There was a problem hiding this comment.
nit: I think this can be removed.
There was a problem hiding this comment.
oops missed that
|
build |
revans2
approved these changes
Jan 29, 2021
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…ata (NVIDIA#1622) * Add in data source v2, csv file and test for arrow copy * remove commented out line
nartal1
pushed a commit
to nartal1/spark-rapids
that referenced
this pull request
Jun 9, 2021
…ata (NVIDIA#1622) * Add in data source v2, csv file and test for arrow copy * remove commented out line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides support for more efficiently copying data to the GPU when a datasource V2 source provides the data as an ArrowColumnVector. The CUDF side of this has already been merged. rapidsai/cudf#7222
This currently only supports primitive types and strings. Decimal types and nested types are not supported. It will fallback to the regular copy code if it sees one of those types not supported.
The integration test require an extra jar which contains a datasource v2 which supplies ArrowColumnVector. I'm looking into pulling that code in and how best to automate those tests, filed #1620 to track that.
You will notice I added a new AccessibleArrowColumnVector. This is because the Spark ArrowColumnVector doesn't have the Arrow ValueVector publicly accessible. I use reflection in here to get a hold of that, but another option is just for user to use AccessibleArrowColumnVector. I would like peoples feedback on whether to keep that or not?
I had to add a shim layer for the Arrow code because Spark 3.1.0 changed the arrow version and ArrowBuf class is now different.