Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ANSI mode for window function tests [databricks] #11073

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Disable ANSI mode for window function tests [databricks] #11073

merged 3 commits into from
Jun 26, 2024

Commits on Jun 17, 2024

  1. Disable ANSI mode for window function tests. 

    Fixes NVIDIA#11019.

Window function tests fail on Spark 4.0 because of NVIDIA#5114 (and NVIDIA#5120 broadly),
because spark-rapids does not support SUM, COUNT, and certain other aggregations
in ANSI mode.

This commit disables ANSI mode tests for the failing window function tests. These may be
revisited, once error/overflow checking is available for ANSI mode in spark-rapids.

Signed-off-by: MithunR <[email protected]>
    @mythrocks
    mythrocks committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    3db464b View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. Switch from @ansi_mode_disabled to @disable_ansi_mode.

    @mythrocks
    mythrocks committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    84945fe View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. Merge remote-tracking branch 'origin/branch-24.08' into spark4-window… 

    …-function-tests
    @mythrocks
    mythrocks committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    12e444c View commit details
    Browse the repository at this point in the history