Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable default cuDF pinned pool #10868

Merged
merged 2 commits into from
May 28, 2024

Conversation

abellina
Copy link
Collaborator

@abellina abellina commented May 22, 2024

This is a revival of #10815 with one notable change.

Waiting for rapidsai/cudf#15815

The cuDF code is no longer going to throw when configureDefaultCudfPinnedPoolSize fails. Instead it's going to return a boolean. If the boolean is true, we successfully disabled the cuDF default pool. Else, it will be false, and we will have 100MB of pinned pool around that we will not use, or we already have called this function ahead of time.

I only anticipate this warning to show up in tests. We call this early enough and we only initialize once, so I don't think we'll ever see this in real life. Even in tests, we will set our own pinned resource, so we will use our own resource no matter what.

@abellina abellina changed the title Disable default pinned pool Disable default cuDF pinned pool May 22, 2024
@sameerz sameerz added the task Work required that improves the product but is not user facing label May 22, 2024
@abellina abellina added bug Something isn't working cudf_dependency An issue or PR with this label depends on a new feature in cudf and removed task Work required that improves the product but is not user facing labels May 22, 2024
@abellina
Copy link
Collaborator Author

build

@abellina abellina merged commit 91bdb92 into NVIDIA:branch-24.06 May 28, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cudf_dependency An issue or PR with this label depends on a new feature in cudf
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants