-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace anonymous classes for SortOrder and FIlterExec overrides #10839
Merged
gerashegalov
merged 11 commits into
NVIDIA:branch-24.06
from
gerashegalov:unbloatGpuOverrides
May 23, 2024
Merged
Replace anonymous classes for SortOrder and FIlterExec overrides #10839
gerashegalov
merged 11 commits into
NVIDIA:branch-24.06
from
gerashegalov:unbloatGpuOverrides
May 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
node being replaced for better diagnostics Signed-off-by: Gera Shegalov <[email protected]>
Signed-off-by: Gera Shegalov <[email protected]>
gerashegalov
changed the title
[WIP] GpuOverrides exception should be tied to SparkPlan node being replaced for better diagnostics
Replace anonymous classes for SortOrder and FIlterExec overrides
May 22, 2024
build |
Signed-off-by: Gera Shegalov <[email protected]>
jlowe
reviewed
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the anonymous class changes, since we're trading class-for-class, making the stacktrace much more useful without adding to the classloading burden. As for the pluginChecks change, that I'm less convinced is a net benefit change.
sql-plugin/src/main/scala/com/nvidia/spark/rapids/SortUtils.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Gera Shegalov <[email protected]>
Signed-off-by: Gera Shegalov <[email protected]>
Signed-off-by: Gera Shegalov <[email protected]>
Signed-off-by: Gera Shegalov <[email protected]>
Signed-off-by: Gera Shegalov <[email protected]>
Signed-off-by: Gera Shegalov <[email protected]>
Signed-off-by: Gera Shegalov <[email protected]>
build |
jlowe
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo PR contributing to #10838
It showcases a coding convention to follow using SortOrder and FilterExec replacements as an example
Signed-off-by: Gera Shegalov [email protected]