Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[auto-merge] branch-24.02 to branch-24.04 [skip ci] [bot] #10523

Closed
wants to merge 3 commits into from

Conversation

nvauto
Copy link
Collaborator

@nvauto nvauto commented Feb 29, 2024

auto-merge triggered by github actions on branch-24.02 to create a PR keeping branch-24.04 up-to-date. If this PR is unable to be merged due to conflicts, it will remain open until manually fix.

@nvauto
Copy link
Collaborator Author

nvauto commented Feb 29, 2024

FAILURE - Unable to auto-merge. Manual operation is required.

{'message': 'Pull Request is not mergeable', 'documentation_url': 'https://docs.github.com/rest/pulls/pulls#merge-a-pull-request'}

Please use the following steps to fix the merge conflicts manually:

# Assume upstream is NVIDIA/spark-rapids remote
git fetch upstream branch-24.02 branch-24.04
git checkout -b fix-auto-merge-conflict-10523 upstream/branch-24.04
git merge upstream/branch-24.02
# Fix any merge conflicts caused by this merge
git commit -am "Merge branch-24.02 into branch-24.04"
git push <personal fork> fix-auto-merge-conflict-10523
# Open a PR targets NVIDIA/spark-rapids branch-24.04

IMPORTANT: Before merging this PR, be sure to change the merging strategy to Create a merge commit (repo admin only).

Once this PR is merged, the auto-merge PR should automatically be closed since it contains the same commit hashes

@NvTimLiu
Copy link
Collaborator

NvTimLiu commented Mar 1, 2024

I'll take care of this merge conflicts

@NvTimLiu NvTimLiu self-assigned this Mar 1, 2024
NvTimLiu and others added 2 commits March 1, 2024 17:05
* Add missed shims for scala2.13

Signed-off-by: Tim Liu <[email protected]>

* Add 351 snapshot shim for the scala2.13 version of plugin jar

Signed-off-by: Tim Liu <[email protected]>

* Remove 351 snapshot shim as spark 3.5.1 has been released

Signed-off-by: Tim Liu <[email protected]>

* Remove scala2.13 351 snapshot shim

Signed-off-by: Tim Liu <[email protected]>

* Remove 351 shim's jason string

Ran `mvn generate-sources -Dshimplify=true -Dshimplify.move=true -Dshimplify.remove.shim=351`

to remove 351 shim's jason string, and fix some unnecessary empty lines that were introduced

Signed-off-by: Tim Liu <[email protected]>

* Update Copyright 2024

Auto copyright by below scripts
```
export SPARK_RAPIDS_AUTO_COPYRIGHTER=ON

./scripts/auto-copyrighter.sh $(git diff --name-only origin/branch-24.04..HEAD)
```

Signed-off-by: Tim Liu <[email protected]>

* Revert "Update Copyright 2024"

This reverts commit 8482847.

* Revert "Remove 351 shim's jason string"

This reverts commit 78d1f00.

* skip 351 from strict checking

* Alien scala2.13/pom.xml to scala2.12 one

Run the script `bash build/make-scala-version-build-files.sh 2.13`

Signed-off-by: Tim Liu <[email protected]>

* pretend 351 is a snapshot in 24.02

Signed-off-by: Gera Shegalov <[email protected]>

* pretend 351 is a SNAPSHOT version

* Revert change of build/shimplify.py

Signed-off-by: Tim Liu <[email protected]>

---------

Signed-off-by: Tim Liu <[email protected]>
Signed-off-by: Gera Shegalov <[email protected]>
Co-authored-by: Raza Jafri <[email protected]>
Co-authored-by: Gera Shegalov <[email protected]>
@NvTimLiu
Copy link
Collaborator

NvTimLiu commented Mar 2, 2024

Fixed by : #10528

@NvTimLiu NvTimLiu closed this Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants