Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Databricks 10.4 runtime from CI #10451

Closed
wants to merge 3 commits into from

Conversation

NvTimLiu
Copy link
Collaborator

Part of #10429

Drop Databricks 10.4 runtime from CI pipelines, @razajafri will help remove 10.4 related source code.

@NvTimLiu NvTimLiu added the build Related to CI / CD or cleanly building label Feb 21, 2024
@NvTimLiu NvTimLiu self-assigned this Feb 21, 2024
Signed-off-by: Tim Liu <[email protected]>
@NvTimLiu
Copy link
Collaborator Author

build

@NvTimLiu
Copy link
Collaborator Author

Draft this PR first,

I'll update CI scripts to drop Databricks 10.4 nightly build and integration test pipelines!

Will merge this PR alone with our nightly build and integration test CI changes.

@NvTimLiu NvTimLiu marked this pull request as draft February 21, 2024 03:34
@NvTimLiu
Copy link
Collaborator Author

NvTimLiu commented Feb 21, 2024

The build/shimplify.py will calculate shim versions from source code via __traverse_source_tree_of_all_shims

So this PR failed as below as not removing 321db shim from source code.

We need to remove sql-plugin/src/main/spark321db/ dir and all the jason string {"spark": "321db"} first to PASS the build.

@razajafri can you help to include this PR into you source change? Thanks!

Error:  Failed to execute goal org.apache.maven.plugins:maven-antrun-plugin:3.1.0:run (shimplify-shim-sources) on project rapids-4-spark-sql_2.12: An Ant BuildException has occured: Traceback (most recent call last):
Error:    File "<script>", line 579, in <module>
Error:    File "<script>", line 354, in task_impl
Error:    File "<script>", line 368, in __generate_symlinks
Error:    File "<script>", line 397, in __traverse_source_tree_of_all_shims
Error:    File "<script>", line 375, in __map_version_array
Error:  AssertionError: all.buildvers in pom.xml does not contain 321db
Error:  
Error:  around Ant part ...<shimplify if="shimplify" />... @ 7:33 in /home/runner/work/spark-rapids/spark-rapids/sql-plugin/target/spark312/antrun/build-main.xml
Error:  -> [Help 1]
Error:  

@jlowe
Copy link
Member

jlowe commented Feb 23, 2024

Superceded by #10474

@jlowe jlowe closed this Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to CI / CD or cleanly building
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants