Add in basic support for JSON generation in BigDataGen and improve performance of from_json #10361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rformance of from_json Signed-off-by: Robert (Bobby) Evans <[email protected]>
andygrove
approved these changes
Feb 2, 2024
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on work done in rapidsai/cudf#14954
In my testing using from_json to pull one column out of a JSON string with only one column in it (10 GiB of data) went from 13.8 seconds to 7.0 seconds. Note that this included reading the 10 GiB from a parquet file too so the speedup is even more.
For longer strings with 512 columns in it and only reading one of the columns (still 10 GiB of data) went from 17.6 seconds to 11.4 seconds.