Add in framework for unbounded to unbounded window agg optimization #10158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert (Bobby) Evans <[email protected]>
Signed-off-by: Robert (Bobby) Evans <[email protected]>
|
build |
|
So it looks like my inc ref count code is causing lots of problems because lots of places are assuming that they can close the SpillableColumnarBatch multiple times. I'll work on removing the check and then file an issue to go look into it. Probably related to the leak detection code we have talked about. |
Signed-off-by: Robert (Bobby) Evans <[email protected]>
|
build |
sameerz
added
the
reliability
Signed-off-by: Robert (Bobby) Evans <[email protected]>
Signed-off-by: Robert (Bobby) Evans <[email protected]>
|
This does a bit more than just the framework now. It has enough code to do the split and some unit tests for that too. @mythrocks please take a look when you have time. |
|
build |
|
build |
1 similar comment
|
build |
|
build |
mythrocks
approved these changes
Feb 6, 2024
NvTimLiu
added a commit
that referenced
this pull request
Apr 15, 2024
Update change log Change roadmap to 24.04 for PRs #10158,#10369,#10358,#10360, to move them into 24.04 PR list from 24.02 Signed-off-by: Tim Liu <[email protected]>
NvTimLiu
added a commit
that referenced
this pull request
Apr 15, 2024
* Update latest changelog [skip ci] Update change log with CLI: \n\n scripts/generate-changelog --token=<GIT_TOKEN> --releases=24.02,24.04 Signed-off-by: jenkins <jenkins@localhost> * Update according to review Signed-off-by: Tim Liu <[email protected]> * Update change log to latest Signed-off-by: Tim Liu <[email protected]> * Update change log Update change log Change roadmap to 24.04 for PRs #10158,#10369,#10358,#10360, to move them into 24.04 PR list from 24.02 Signed-off-by: Tim Liu <[email protected]> --------- Signed-off-by: jenkins <jenkins@localhost> Signed-off-by: Tim Liu <[email protected]> Co-authored-by: jenkins <jenkins@localhost> Co-authored-by: Tim Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial pass at setting up the framework needed for the new unbounded to unbounded window aggregation performance and memory optimization. This is part of #10114
The goal of this really is to get enough framework in place that both I and @mythrocks can work on different parts together.