Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Support Size operation #79

Closed
revans2 opened this issue May 29, 2020 · 2 comments
Closed

[FEA] Support Size operation #79

revans2 opened this issue May 29, 2020 · 2 comments
Assignees
@nartal1
Labels
feature request New feature or request SQL part of the SQL/Dataframe plugin

Comments

@revans2
Copy link
Collaborator

revans2 commented May 29, 2020

Is your feature request related to a problem? Please describe.
Once we have support for arrays #16 and/or maps #44 we should support the cardinality and size SQL functions.
@revans2 revans2 added feature request New feature or request ? - Needs Triage Need team to review and classify SQL part of the SQL/Dataframe plugin labels May 29, 2020
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Sep 1, 2020
@revans2
Copy link
Collaborator Author

revans2 commented Feb 18, 2021

CUDF has added in support for array size.

https://github.com/rapidsai/cudf/blob/af2fc1b1f326c244698b7543a37858937c12d42e/cpp/include/cudf/lists/count_elements.hpp#L49-L51

We just need to put in JNI APIs for this and then we should be able to make it work.

@revans2 revans2 mentioned this issue Feb 18, 2021
Closed
@nartal1 nartal1 self-assigned this Oct 19, 2021
@nartal1
Copy link
Collaborator

nartal1 commented Oct 26, 2021 •
edited
Loading

This is already supported. I built cudf and was looking to add JNI for count_elements to support GpuSize but it was already present. After further digging, saw we already have plugin support for this.
cudf PR - rapidsai/cudf#7651
Plugin PR - #1972 , #1981

Verified that cardinality and size runs on GPU and checked with Bobby if this can be closed. Closing this issue.

@nartal1 nartal1 closed this as completed Oct 26, 2021
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this issue Nov 30, 2023
@nvauto
Update submodule cudf to 496f452 (NVIDIA#79)
d1059b7 
Signed-off-by: spark-rapids automation <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nartal1 nartal1

Labels
feature request New feature or request SQL part of the SQL/Dataframe plugin
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@revans2 @sameerz @nartal1