Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Add GpuMapConcat support for nested (array, struct, map) types. #5559

Closed
2 tasks done
HaoYang670 opened this issue May 20, 2022 · 4 comments
Closed
2 tasks done
Assignees
Labels
feature request New feature or request

Comments

@HaoYang670
Copy link
Collaborator

HaoYang670 commented May 20, 2022

Is your feature request related to a problem? Please describe.
This is a follow on issue of #5533.

Describe the solution you'd like
GpuMapConcat should support arbitrary nested types for values once rapidsai/cudf#10890 is merged. For keys we need rapidsai/cudf#11093 assuming that it also updates drop_list_duplicates. These do not have to be done at the same time. We can split them up into separate PRs for keys and values:

@HaoYang670 HaoYang670 added feature request New feature or request ? - Needs Triage Need team to review and classify labels May 20, 2022
@HaoYang670 HaoYang670 self-assigned this May 20, 2022
@revans2 revans2 changed the title [FEA] Add GpuConcat and GpuMapConcat support for nested (array, struct, map) types. [FEA] Add GpuMapConcat support for nested (array, struct, map) types. May 20, 2022
@revans2
Copy link
Collaborator

revans2 commented May 20, 2022

I removed GpuConcat because it is covered by #5542

@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label May 24, 2022
@HaoYang670

This comment was marked as resolved.

@GaryShen2008
Copy link
Collaborator

Hi @HaoYang670 , seems rapidsai/cudf#11093 has been closed. Can we support the nested type keys now?

@HaoYang670
Copy link
Collaborator Author

Close this issue as we have completed the tasks in the checklist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants