Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] disable any kind of warnings about ExecutedCommandExec not being on the GPU #499

Closed
revans2 opened this issue Aug 3, 2020 · 0 comments · Fixed by #660
Closed

[FEA] disable any kind of warnings about ExecutedCommandExec not being on the GPU #499

revans2 opened this issue Aug 3, 2020 · 0 comments · Fixed by #660
Assignees
@revans2
Labels
feature request New feature or request

Comments

@revans2
Copy link
Collaborator

revans2 commented Aug 3, 2020 •
edited
Loading

We are never going to run anything from ExecutedCommandExec on the GPU. It only does metadata operations. When the plugin explains what is and isn't on the GPU we should either just not print anything out for these parts of the plan, or we should print out something saying it is supposed to run on the CPU.

This is also for AlterNamespaceSetPropertiesExec, CreateNamespaceExec, AlterTableExec, CreateTableExec, DeleteFromTableExec, DescribeNamespaceExec, DescribeTableExec, DropNamespaceExec, AtomicReplaceTableExec, RefreshTableExec, RenameTableExec, ReplaceTableExec, SetCatalogAndNamespaceExec, ShowCurrentNamespaceExec, ShowNamespacesExec, ShowTablePropertiesExec, ShowTablesExec, and DropTableExec
@revans2 revans2 added feature request New feature or request ? - Needs Triage Need team to review and classify labels Aug 3, 2020
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Aug 4, 2020
@revans2 revans2 mentioned this issue Aug 28, 2020
Closed
@revans2 revans2 self-assigned this Sep 3, 2020
@revans2 revans2 mentioned this issue Sep 3, 2020
Merged
pxLi pushed a commit to pxLi/spark-rapids that referenced this issue May 12, 2022
@yhwen
Added a missing check in. (NVIDIA#499)
28282fa
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this issue Nov 30, 2023
@nvauto
Update submodule cudf to 2c06e51 (NVIDIA#499)
9578f9e 
Signed-off-by: spark-rapids automation <[email protected]>

Signed-off-by: spark-rapids automation <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@revans2 revans2

Labels
feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add in neverReplaceExec and several rules for it revans2/spark-rapids
2 participants
@revans2 @sameerz