Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Update GpuCoalesceBatchesSuite to work with AQE enabled #454

Closed
andygrove opened this issue Jul 28, 2020 · 2 comments · Fixed by #567
Closed

[FEA] Update GpuCoalesceBatchesSuite to work with AQE enabled #454

andygrove opened this issue Jul 28, 2020 · 2 comments · Fixed by #567
Assignees
@andygrove @nartal1
Labels
feature request New feature or request P0 Must have for release
Milestone
Aug 3 - Aug 14

Comments

@andygrove
Copy link
Contributor

Is your feature request related to a problem? Please describe.
GpuCoalesceBatchesSuite tests fail when AQE is enabled, because they don't use the final execution plan when asserting that the plan is correct.

Describe the solution you'd like
I would like to be able to run the tests with AQE enabled.

Describe alternatives you've considered
N/A

Additional context
N/A
@andygrove andygrove added feature request New feature or request ? - Needs Triage Need team to review and classify labels Jul 28, 2020
@andygrove andygrove added this to the Jul 20 - Jul 31 milestone Jul 28, 2020
@andygrove andygrove self-assigned this Jul 28, 2020
@sameerz sameerz added P0 Must have for release and removed ? - Needs Triage Need team to review and classify labels Jul 28, 2020
@nartal1 nartal1 self-assigned this Aug 5, 2020
@andygrove
Copy link
Contributor Author

The coalesce HostColumnarToGpu test doen't make sense as written when AQE is enabled. It is checking that no part of the plan runs on CPU except for the Parquet scan, but when AQE is enabled, the Parquet scan becomes a query stage that runs on the CPU and results in transitions that the test is not expecting.

I don't think there is value in modifying this test to work with AQE and we should just ignore it if AQE is enabled.

@andygrove andygrove mentioned this issue Aug 14, 2020
Merged
@andygrove andygrove linked a pull request Aug 18, 2020 that will close this issue
Explicitly disable AQE in one test #567
Merged
@andygrove
Copy link
Contributor Author

Fixed in #567

pxLi pushed a commit to pxLi/spark-rapids that referenced this issue May 12, 2022
@yhwen
Not allow shutdown while still jobs running. (NVIDIA#454)
49bc48c 
* Not allow shutdown while still jobs running.

* Added protection for restart.
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this issue Nov 30, 2023
@nvauto
Merge pull request NVIDIA#454 from NVIDIA/bot-auto-merge-branch-22.08
dc3fae2 
[auto-merge] bot-auto-merge-branch-22.08 to branch-22.10 [skip ci] [bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andygrove andygrove

@nartal1 nartal1

Labels
feature request New feature or request P0 Must have for release
Projects
None yet
Milestone
Aug 3 - Aug 14
Development

Successfully merging a pull request may close this issue.

Explicitly disable AQE in one test andygrove/spark-rapids
3 participants
@andygrove @sameerz @nartal1