Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Audit GenerateExec #228

Closed
kuhushukla opened this issue Jun 19, 2020 · 6 comments
Closed

[FEA] Audit GenerateExec #228

kuhushukla opened this issue Jun 19, 2020 · 6 comments
Assignees
@nartal1
Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf feature request New feature or request P1 Nice to have for release

Comments

@kuhushukla
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

  • Ensure Spark and Rapids plugin version of the exec match functionality.

  • Verify Config specific to the operator match.

  • Verify API is consistent and fully translated.

  • Port relevant tests.
@kuhushukla kuhushukla added feature request New feature or request ? - Needs Triage Need team to review and classify labels Jun 19, 2020
@nartal1
Copy link
Collaborator

nartal1 commented Jun 19, 2020

Configs don't match and mainly due to not having array support. Will resume once we have Array type support.

@kuhushukla kuhushukla removed the ? - Needs Triage Need team to review and classify label Jul 2, 2020
@sameerz sameerz added this to the Jul 6 - Jul 17 milestone Jul 6, 2020
@kuhushukla
Copy link
Collaborator Author

@nartal1 can u list the configs that dont match here for completeness? Thanks!

@sameerz sameerz added the P0 Must have for release label Jul 22, 2020
@nartal1 nartal1 removed this from the Jul 20 - Jul 31 milestone Aug 3, 2020
@nartal1
Copy link
Collaborator

nartal1 commented Aug 11, 2020 •
edited
Loading

@nartal1 can u list the configs that dont match here for completeness? Thanks!

Sorry missed this. It should have been "API is not translated fully" instead of configs. Took a look again and we are good on configs(no configs on Spark side).

@nartal1
Copy link
Collaborator

nartal1 commented Aug 18, 2020

To make it work, we would need some operations support(explode, posexplode) from libcudf.
There was already an issue filed for explode support. Created an issue for posexplode.
Depends on rapidsai/cudf#2975 and rapidsai/cudf#6025

@nartal1 nartal1 removed this from the Aug 17 - Aug 28 milestone Aug 18, 2020
@nartal1
Copy link
Collaborator

nartal1 commented Aug 18, 2020

Removing it from current milestone.
@sameerz - I am not sure if we could complete it by Release-0.2 as it depends on libcudf.
Please let me know if we can remove this from Release-0.2.

@kuhushukla kuhushukla added P1 Nice to have for release and removed P0 Must have for release labels Oct 23, 2020
@sameerz sameerz added the cudf_dependency An issue or PR with this label depends on a new feature in cudf label Feb 18, 2021
@nartal1
Copy link
Collaborator

nartal1 commented Oct 27, 2021

New interface GpuGenerator was added and it makes the GpuGenerateExec API fully translated to GenerateExec.
#1843 . Closing this.

@nartal1 nartal1 closed this as completed Oct 27, 2021
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this issue Nov 30, 2023
@nvauto
Update submodule cudf to 4913a9b (NVIDIA#228)
04e2a93 
Signed-off-by: spark-rapids automation <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nartal1 nartal1

Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf feature request New feature or request P1 Nice to have for release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sameerz @kuhushukla @nartal1