Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] add in support for dayfirst formats in the CSV parser #123

Closed
revans2 opened this issue Jun 8, 2020 · 0 comments · Fixed by #4938
Closed

[FEA] add in support for dayfirst formats in the CSV parser #123

revans2 opened this issue Jun 8, 2020 · 0 comments · Fixed by #4938
Assignees
Labels
feature request New feature or request P2 Not required for release SQL part of the SQL/Dataframe plugin

Comments

@revans2
Copy link
Collaborator

revans2 commented Jun 8, 2020

Is your feature request related to a problem? Please describe.
In the cudf CSV parser there is the possibility to support formats like 'dd/MM/yyyy' or 'dd-MM-yyyy' for dates, and similarly for timestamps. The issue is that we need to expose that config setting through the cudf java API and we need to detect it in both the date and the timestamp formats to
see if we can support it. Because there is only one setting for this in the file we would have to make sure that both of the formats were consistent or if both are used we fall back to the CPU.

@revans2 revans2 added feature request New feature or request ? - Needs Triage Need team to review and classify SQL part of the SQL/Dataframe plugin labels Jun 8, 2020
@revans2 revans2 changed the title [FEA] add in support for dayfirst formats in teh CSV parser [FEA] add in support for dayfirst formats in the CSV parser Jun 8, 2020
@sameerz sameerz added P2 Not required for release and removed ? - Needs Triage Need team to review and classify labels Aug 18, 2020
@andygrove andygrove self-assigned this Feb 24, 2022
@andygrove andygrove added this to the Feb 14 - Feb 25 milestone Feb 24, 2022
@andygrove andygrove linked a pull request Feb 24, 2022 that will close this issue
3 tasks
@andygrove andygrove removed a link to a pull request Feb 24, 2022
3 tasks
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this issue Nov 30, 2023
Signed-off-by: spark-rapids automation <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request P2 Not required for release SQL part of the SQL/Dataframe plugin
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants