Add AQEShuffleRead WriteFiles execs to the supportedOps and score files #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cindyyuanjiang <[email protected]>
cindyyuanjiang
added
bug
amahussein
reviewed
Apr 24, 2024
There was a problem hiding this comment.
Thanks @cindyyuanjiang
@parthosa I thought you worked on adding support for CheckOverflowInTableInsert before.
amahussein
requested changes
Apr 24, 2024
amahussein
changed the title
My PR had not made any changes in these files because I was not able to reproduce this expression in physical plan and we concluded that this expression would never show up. Although I think we should have these updated scores. Thanks @cindyyuanjiang for updating them. |
parthosa
previously approved these changes
Apr 25, 2024
Signed-off-by: cindyyuanjiang <[email protected]>
|
Thanks @amahussein @parthosa! I have updated the scores for the new operators. |
nartal1
approved these changes
Apr 25, 2024
amahussein
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #865
This PR updates the CSV and override files for all remaining execs or expressions marked as
TNEWin #865.