-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AQEShuffleRead WriteFiles execs to the supportedOps and score files #963
Conversation
Signed-off-by: cindyyuanjiang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cindyyuanjiang
@parthosa I thought you worked on adding support for CheckOverflowInTableInsert
before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets add them to the score sheets -- if they are missing -- just in case we implemented classes for those execs
My PR had not made any changes in these files because I was not able to reproduce this expression in physical plan and we concluded that this expression would never show up. Although I think we should have these updated scores. Thanks @cindyyuanjiang for updating them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @cindyyuanjiang
Signed-off-by: cindyyuanjiang <[email protected]>
Thanks @amahussein @parthosa! I have updated the scores for the new operators. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cindyyuanjiang !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cindyyuanjiang
LGTME
Closes #865
This PR updates the CSV and override files for all remaining execs or expressions marked as
TNEW
in #865.