Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding more metrics and options for qual validation #926

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Adding more metrics and options for qual validation #926

merged 2 commits into from
Apr 11, 2024

Conversation

mattahrens
Copy link
Collaborator

  • Switching to new CLI
  • Adding verbose and platform argument support
  • Additional metrics to output

@mattahrens mattahrens self-assigned this Apr 10, 2024
@mattahrens mattahrens added the core_tools Scope the core module (scala) label Apr 10, 2024
cindyyuanjiang
cindyyuanjiang previously approved these changes Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@cindyyuanjiang cindyyuanjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mattahrens! Just a minor nit.

amahussein
amahussein approved these changes Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@amahussein amahussein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mattahrens
LGTME

@mattahrens mattahrens merged commit 4291d1a into NVIDIA:dev Apr 11, 2024
15 checks passed
@mattahrens mattahrens deleted the mahrens-add-more-qual-validation-metrics branch April 11, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amahussein amahussein amahussein approved these changes

@cindyyuanjiang cindyyuanjiang cindyyuanjiang left review comments

Assignees

@mattahrens mattahrens

Labels
core_tools Scope the core module (scala)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattahrens @cindyyuanjiang @amahussein