Refactor find_matches_for_node return values
#920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cindyyuanjiang <[email protected]>
cindyyuanjiang
requested review from
amahussein,
nartal1 and
parthosa
and removed request for
amahussein
cindyyuanjiang
added
the
user_tools
nartal1
approved these changes
Apr 10, 2024
parthosa
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
find_matches_for_nodereturns a mapping of CPU to GPU machines and a mapping of supported GPUs. It has 5 use sites, but 4 of them only need one of the mappings.This PR refactors the function return values. For
onprem, the implementation can directly getsupported_mc_mapwithout runningfind_matches_for_node.