Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Divide and multiple interval expressions as supported #917

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

nartal1
Copy link
Collaborator

@nartal1 nartal1 commented Apr 9, 2024

This contributes to #865

DivideDTInterval and DivideDMInterval are divide operation of interval type by numeric. These are selected based on the type of input for "Divide" operator in Analyzer - link.

        case d @ Divide(l, r, mode) if d.childrenResolved => (l.dataType, r.dataType) match {
          case (CalendarIntervalType, _) => DivideInterval(l, r, mode == EvalMode.ANSI)
          case (_: YearMonthIntervalType, _) => DivideYMInterval(l, r)
          case (_: DayTimeIntervalType, _) => DivideDTInterval(l, r)
          case _ => d
        }

So we would not see any new expression rather it would be a Divide expression in the eventlog.
It's similar for Multiplication of Interval types by numeric (MultiplyDTInterval, MultiplyYMInterval).
Added these are supported for completion and removed from override_config_supported.json file.
Adding scores is not required for these expressions as it would be covered by "Divide" expression.

@nartal1 nartal1 added the core_tools Scope the core module (scala) label Apr 9, 2024
@nartal1 nartal1 self-assigned this Apr 9, 2024
Copy link
Collaborator

@amahussein amahussein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nartal1
Yes, I think we don't need to do more than this.

@nartal1 nartal1 merged commit 17613ee into NVIDIA:dev Apr 9, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core_tools Scope the core module (scala)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants