Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PythonMapInArrowExec and MapInArrowExec #913

Merged
merged 4 commits into from
Apr 9, 2024

Conversation

parthosa
Copy link
Collaborator

@parthosa parthosa commented Apr 8, 2024

Fixes #884. This PR adds support for PythonMapInArrowExec in tools.

Note: For Spark 4.0, we might have to revisit as this exec is renamed to MapInArrowExec.
Spark Commit: apache/spark@ed9a3a8

@parthosa parthosa added bug Something isn't working core_tools Scope the core module (scala) labels Apr 8, 2024
@parthosa parthosa self-assigned this Apr 8, 2024
Copy link
Collaborator

@amahussein amahussein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I filed an audit issue NVIDIA/spark-rapids#10673 to be aware of the className change

On the tools side, Lets add MapInArrowExec/MapInArrow in this PR so we can be compatible with spark-4 waiting for the plugin to extend the shims.

Don't forget to add it to the score sheets.

Signed-off-by: Partho Sarthi <[email protected]>
@parthosa parthosa requested a review from amahussein April 9, 2024 18:27
@amahussein amahussein changed the title Add support for PythonMapInArrowExec Add support for PythonMapInArrowExec and MapInArrowExec Apr 9, 2024
Copy link
Collaborator

@amahussein amahussein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTME
Thanks @parthosa

@parthosa parthosa merged commit 625dc09 into NVIDIA:dev Apr 9, 2024
15 checks passed
@parthosa parthosa deleted the spark-rapids-tools-865-884 branch April 9, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core_tools Scope the core module (scala)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Support for PythonMapInArrowExec
2 participants