-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jar argument to spark_rapids CLI #902
Conversation
Signed-off-by: Ahmed Hussein (amahussein) <[email protected]> Fixes NVIDIA#901
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @amahussein ! LGTM.
Have a question:
What should be the behavior if the tools_jar version doesn't match with user-tools. i.e if the user accidently provides the old tools_jar version path, should we throw an error OR let it go through using the old jar itself? Or do we already have a check in place for this.
Since, we cannot verify the version from the file's name, the way to do it is to process the POM file inside the jar to check the version. This implies that users with custom builds/versioning won't be able to use their jars against the CLI. Rendering the feature to be useless. So, I would say that it is user's responsibility. Even if we process the pom to display a warning without completely bailing out, the benefit is not worth the effort IMHO. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @amahussein!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @amahussein.
Signed-off-by: Ahmed Hussein (amahussein) [email protected]
Fixes #901