-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support driverlog argument in profiler CLI #897
Conversation
Signed-off-by: Ahmed Hussein (amahussein) <[email protected]> Fixes NVIDIA#676 - This code allows passing `--driverlog` argument to the `spark_rapids` CLI - The spark_rapids profiling cmd can accept none eventlogs - Added unit test to the spark_rapids that eventlogs can be empty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @amahussein ! Overall LGTM. I wanted to understand the output from user tools if only driverlog is provided in the commandline.
Signed-off-by: Ahmed Hussein (amahussein) <[email protected]>
So far, the user-tools does not consume the output from the driverlog. Internally: our devs can directly consume the CSV files and won't rely on the STDout and they will still be able to:
From end-user perspective: We probably need to integrate the output from the driverlog-processor to come-up with a meaningful summary. For example, we can integrate the output of driverlog into the AutoTuner as a way to give insights to the operators that caused any sort of fallbacks. For followups: We can file a separate issue to consume output of driverlog in the user-tools, but I believe it will be a redundant and low-priority task anyway. The other option is to take this into consideration while we are planning the revamp of AutoTuner running on top of both Qual/Prof tools. |
Thanks @amahussein for the explanation. I think we can take this into consideration while we are planning the revamp of Autotuner. It might be good to explore if we can look into both driver-log output and metrics from the Prof tools for Autotuner recommendation. |
Signed-off-by: Ahmed Hussein (amahussein) [email protected]
Fixes #676
--driverlog
argument to thespark_rapids
CLI