Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add action column to qual execs output #859

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Add action column to qual execs output #859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29d5358
Add action column to qual execs output
amahussein Mar 20, 2024
44a5bf6
remove execToExpr map from qualificationInfo
amahussein Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions core/src/main/scala/com/nvidia/spark/rapids/tool/planparser/SQLPlanParser.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import org.apache.spark.sql.rapids.tool.util.ToolsPlanGraph

object OpActions extends Enumeration {
type OpAction = Value
val IgnoreNoPerf, IgnorePerf, Triage = Value
val NONE, IgnoreNoPerf, IgnorePerf, Triage = Value
}

object OpTypes extends Enumeration {
Expand Down Expand Up @@ -143,15 +143,19 @@ case class ExecInfo(
if (reason.nonEmpty) UnsupportedReasons.CUSTOM_REASON(reason) else knownReason
}

private def getOpAction: OpActions.OpAction = {
def getOpAction: OpActions.OpAction = {
// shouldRemove is checked first because sometimes an exec could have both flag set to true,
// but then we care about having the "NoPerf" part
if (shouldRemove) {
OpActions.IgnoreNoPerf
} else if (shouldIgnore) {
OpActions.IgnorePerf
} else {
OpActions.Triage
if (isSupported) {
OpActions.NONE
} else {
if (shouldRemove) {
OpActions.IgnoreNoPerf
} else if (shouldIgnore) {
OpActions.IgnorePerf
} else {
OpActions.Triage
}
}
}

Expand Down
Loading
Loading