Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix implementation of processSQLPlanMetrics in Profiler #853

Merged
merged 3 commits into from
Mar 14, 2024
Merged

Fix implementation of processSQLPlanMetrics in Profiler #853

merged 3 commits into from
Mar 14, 2024

Commits on Mar 14, 2024

  1. Fix implementation of processSQLPlanMetrics in Profiler 

    Signed-off-by: Ahmed Hussein (amahussein) <[email protected]>

Fixes NVIDIA#851

- The implementation of `processSQLPlanMetrics` to parameterize the
  information based on the SqlID
- Added a buffer `SqlPlanInfoGraphBuffer` to capture the construction of
  the SprkSqlPlan. Otherwise, the graph we constructed multiple times
which was not efficient
- Changed JDOC in AutoTuner to cleanup build warning.
- Refactoring the implementation of `jobAndStageMetricsAggregation`
  reduced both Mem and CPU by 20%
- Made a few changes in `jobAndStageMetricsAggregation` which reduced the
  total memory allcated by this method
- Changed the type of local variables from `Seq` to `Set`
- Removed some local variables that were causing memory bloats
- Renamed `GenerateDot.SparkPlanGraph` to `SparkPlanGraphForDot` because
  it was conflicting with Spark.SparkPlanGraph class in the imports
- Fixed unit test
- Added a new Set to keep track of missing event classes which reduces
  the noise in the log files.
    @amahussein
    amahussein committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    fa5713c View commit details
    Browse the repository at this point in the history

  2. Optimize potential problems constructions 

    Signed-off-by: Ahmed Hussein (amahussein) <[email protected]>
    @amahussein
    amahussein committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    dafff22 View commit details
    Browse the repository at this point in the history

  3. Address code review-1 

    Signed-off-by: Ahmed Hussein (amahussein) <[email protected]>
    @amahussein
    amahussein committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    2c31233 View commit details
    Browse the repository at this point in the history