-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Photon-specific SQL Metrics #1390
Conversation
Signed-off-by: Partho Sarthi <[email protected]>
Signed-off-by: Partho Sarthi <[email protected]>
Signed-off-by: Partho Sarthi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @parthosa
just a small nit
core/src/main/scala/org/apache/spark/sql/rapids/tool/store/AccumManager.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Partho Sarthi <[email protected]>
core/src/main/scala/com/nvidia/spark/rapids/tool/planparser/DatabricksParseHelper.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @parthosa! a minor nit.
Signed-off-by: Partho Sarthi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @parthosa! LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @parthosa ! LGTM.
Fixes #1388
This PR adds support for Photon-specific SQL metrics as:
cumulative time
metric that can be used as a replacement for thescan time
metric.shuffle write time
can be reconstructed using the following metrics:peak memory usage
metric can be used for thepeak execution memory
metric.Code Changes
AppSparkMetricsAnalyzer.scala
: Added logic to handle Photon-specific metrics for peak memory and shuffle write time, utilizing accumulators instead of task metrics. [1] [2] [3]DatabricksParseHelper.scala
: Introduced methods and constants to identify and process Photon I/O metrics. [1] [2]DataSourceView.scala
: Updated the data source view to include Photon-specific I/O metrics and refactored the method to fetch I/O metrics. [1] [2] [3]AccumManager.scala
: Added a utility method to apply functions to entries in theaccumInfoMap
.Tests: