Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to ArrayJoin in Qualification tool #1345

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Add support to ArrayJoin in Qualification tool #1345

merged 1 commit into from
Sep 17, 2024

Conversation

amahussein
Copy link
Collaborator

Signed-off-by: Ahmed Hussein [email protected]

Fixes #1341

  • Add ArrayJoin to supportedExprs.csv and update operators sheets
  • Add a unit test to verify that arrayJoin appearing in project is marked as supported

@amahussein
Add support to ArrayJoin in Qualification tool
f740459 
Signed-off-by: Ahmed Hussein <[email protected]>

Fixes NVIDIA#1341

- Add `ArrayJoin` to supportedExprs.csv and update operators sheets
- Add a unit test to verify that arrayJoin appearing in project is
  marked as supported
@amahussein amahussein added feature request New feature or request core_tools Scope the core module (scala) labels Sep 16, 2024
@amahussein amahussein self-assigned this Sep 16, 2024
cindyyuanjiang
cindyyuanjiang approved these changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@cindyyuanjiang cindyyuanjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amahussein! LGTM.

nartal1
nartal1 approved these changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@nartal1 nartal1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amahussein!

@amahussein amahussein merged commit d3b9a59 into NVIDIA:dev Sep 17, 2024
15 checks passed
@amahussein amahussein deleted the rapids-tools-1341 branch September 17, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cindyyuanjiang cindyyuanjiang cindyyuanjiang approved these changes

@nartal1 nartal1 nartal1 approved these changes

Assignees

@amahussein amahussein

Labels
core_tools Scope the core module (scala) feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Add support to array_join expression in Qualification tool
3 participants
@amahussein @cindyyuanjiang @nartal1