Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] spark_rapids CLI help cmd still shows cost savings #1317

Merged
merged 4 commits into from
Aug 28, 2024
Merged

[DOC] spark_rapids CLI help cmd still shows cost savings #1317

merged 4 commits into from
Aug 28, 2024

Conversation

cindyyuanjiang
Copy link
Collaborator

When running spark_rapids -- --help, the console still shows some cost savings info. This PR removes them and fixes some typos.

@cindyyuanjiang cindyyuanjiang self-assigned this Aug 26, 2024
@cindyyuanjiang cindyyuanjiang added documentation Improvements or additions to documentation user_tools Scope the wrapper module running CSP, QualX, and reports (python) labels Aug 26, 2024
@cindyyuanjiang
remove unused arg
f33a172 
Signed-off-by: cindyyuanjiang <[email protected]>
parthosa
parthosa previously approved these changes Aug 27, 2024
View reviewed changes
amahussein
amahussein requested changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@amahussein amahussein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cindyyuanjiang for making those fixes.

user_tools/pyproject.toml Outdated Show resolved Hide resolved
user_tools/src/spark_rapids_tools/cmdli/tools_cli.py Outdated Show resolved Hide resolved
user_tools/src/spark_rapids_tools/cmdli/tools_cli.py Outdated Show resolved Hide resolved
user_tools/src/spark_rapids_tools/cmdli/tools_cli.py Outdated Show resolved Hide resolved
@cindyyuanjiang
addressed review feedback
47b36e7 
Signed-off-by: cindyyuanjiang <[email protected]>
amahussein
amahussein approved these changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@amahussein amahussein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Cindy!

parthosa
parthosa approved these changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@parthosa parthosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cindyyuanjiang. LGTM.

@cindyyuanjiang cindyyuanjiang merged commit 9710ff8 into NVIDIA:dev Aug 28, 2024
14 checks passed
@cindyyuanjiang cindyyuanjiang deleted the improve-tools-help-docs branch August 28, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthosa parthosa parthosa approved these changes

@amahussein amahussein amahussein approved these changes

@nartal1 nartal1 Awaiting requested review from nartal1

@tgravescs tgravescs Awaiting requested review from tgravescs

Assignees

@cindyyuanjiang cindyyuanjiang

Labels
documentation Improvements or additions to documentation user_tools Scope the wrapper module running CSP, QualX, and reports (python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cindyyuanjiang @tgravescs @parthosa @amahussein