Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qualification tool - Add option to filter by minimum event log size #1291

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

tgravescs
Copy link
Collaborator

@tgravescs tgravescs commented Aug 15, 2024

Similar to #1275, bad here filter out files smaller then a certain size. This allows users to do ranges.

  -m, --min-event-log-size  <arg>    Process only application event logs whose
                                     size is greater than the size specified.
                                     Valid units of size are
                                     b(bytes),k(kilobytes),m(megabytes),g(gigabytes).
                                     If no units are specified, the size is
                                     assumed to be m. Note, this does not
                                     support event log rolling which puts
                                     multiple event logs for the same
                                     application into a single directory.

Manually tested. Tested with this option alone and then also with max size and the filter criteria to make sure all work together.

@tgravescs tgravescs added the feature request New feature or request label Aug 15, 2024
@tgravescs tgravescs self-assigned this Aug 15, 2024
kuhushukla
kuhushukla previously approved these changes Aug 15, 2024
parthosa
parthosa previously approved these changes Aug 15, 2024
Copy link
Collaborator

@parthosa parthosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tgravescs. nit: Short flag -m might conflict with max filter arg.

@tgravescs
Copy link
Collaborator Author

actually it looks like it changed -m to be min instead of max, let me look at that

@tgravescs tgravescs dismissed stale reviews from parthosa and kuhushukla via 1ca900e August 15, 2024 19:28
@tgravescs
Copy link
Collaborator Author

fixed the short -m option to go back to --max-event-log-size. I also changed this min to be >= as I think that makes more sense to user.

  -m, --max-event-log-size  <arg>    Process only application event logs whose
                                     size is less than or equal to the size
                                     specified. Valid units of size are
                                     b(bytes),k(kilobytes),m(megabytes),g(gigabytes).
                                     If no units are specified, the size is
                                     assumed to be m. Note, this does not
                                     support event log rolling which puts
                                     multiple event logs for the same
                                     application into a single directory.
      --max-sql-desc-length  <arg>   Maximum length of the SQL description
                                     string output with the per sql output.
                                     Default is 100.
      --min-event-log-size  <arg>    Process only application event logs whose
                                     size is greater than or equal to the size
                                     specified. Valid units of size are
                                     b(bytes),k(kilobytes),m(megabytes),g(gigabytes).
                                     If no units are specified, the size is
                                     assumed to be m. Note, this does not
                                     support event log rolling which puts
                                     multiple event logs for the same
                                     application into a single directory.

Copy link
Collaborator

@parthosa parthosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tgravescs.

@tgravescs tgravescs merged commit 28f4756 into NVIDIA:dev Aug 15, 2024
14 checks passed
@tgravescs tgravescs deleted the minsizefilter branch August 15, 2024 21:26
@parthosa parthosa added the core_tools Scope the core module (scala) label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core_tools Scope the core module (scala) feature request New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants