Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused argument --target_platform in Python Tool #1279

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

parthosa
Copy link
Collaborator

Fixes #1277. This PR removes the usused argument --target_platform. It is used to recommend cluster shape and cost savings for onprem platform.

        :param target_platform: Cost savings and speedup recommendation for comparable cluster in
                target_platform based on on-premises cluster configuration.

                Currently only `dataproc` is supported for target_platform.
                If not provided, the final report will be limited to GPU speedups only without
                cost-savings.

This argument should be removed because:

  1. For onprem, Scala Tool now generates recommended cluster shape and tuning configs
  2. We do not do cost savings.

@parthosa parthosa added bug Something isn't working user_tools Scope the wrapper module running CSP, QualX, and reports (python) labels Aug 12, 2024
@parthosa parthosa self-assigned this Aug 12, 2024
@parthosa parthosa merged commit bec93f0 into NVIDIA:dev Aug 12, 2024
15 checks passed
@parthosa parthosa deleted the spark-rapids-tools-1277 branch August 12, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working user_tools Scope the wrapper module running CSP, QualX, and reports (python)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Unused argument --target_platform should be removed from python tool
2 participants