Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up tools after removing CLI dependency #1256

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Clean up tools after removing CLI dependency #1256

merged 1 commit into from
Aug 7, 2024

Conversation

cindyyuanjiang
Copy link
Collaborator

Contributes to #1191

Changes

  • After removing CLI dependency for retrieving instance type descriptions, there are some unused code in tools. This PR cleans up the dead code.
  • This PR refactors common function definitions into their parent class.

Testing

  • Ran qualification tools on emr, dataproc, datbricks-aws/azure platforms with cluster name and cluster properties file

@cindyyuanjiang cindyyuanjiang mentioned this pull request Aug 2, 2024
Closed
@cindyyuanjiang cindyyuanjiang changed the title Cleaned up tools after removing CLI dependency Clean up tools after removing CLI dependency Aug 2, 2024
@cindyyuanjiang cindyyuanjiang self-assigned this Aug 2, 2024
@cindyyuanjiang cindyyuanjiang added the user_tools Scope the wrapper module running CSP, QualX, and reports (python) label Aug 2, 2024
parthosa
parthosa approved these changes Aug 5, 2024
View reviewed changes
Copy link
Collaborator

@parthosa parthosa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cindyyuanjiang. Labelling the methods as # TODO: to be deprecated was a great idea.

amahussein
amahussein approved these changes Aug 7, 2024
View reviewed changes
Copy link
Collaborator

@amahussein amahussein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cindyyuanjiang
LGTME

@cindyyuanjiang cindyyuanjiang merged commit 5c01aa4 into NVIDIA:dev Aug 7, 2024
15 checks passed
@cindyyuanjiang cindyyuanjiang deleted the spark-rapids-tools-1191-refactor branch August 7, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthosa parthosa parthosa approved these changes

@amahussein amahussein amahussein approved these changes

Assignees

@cindyyuanjiang cindyyuanjiang

Labels
user_tools Scope the wrapper module running CSP, QualX, and reports (python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cindyyuanjiang @parthosa @amahussein